Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] MIP-50: Insured Native Bridge #50

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

l-monninger
Copy link
Contributor

@l-monninger l-monninger commented Nov 6, 2024

Summary

MIP-50

@l-monninger l-monninger requested a review from apenzk as a code owner November 6, 2024 18:13
@l-monninger l-monninger changed the title Insured Bridge [draft] MIP-50: Insured Bridge Nov 6, 2024
@apenzk apenzk changed the title [draft] MIP-50: Insured Bridge [review] MIP-50: Insured Bridge Nov 12, 2024
MIP/mip-n/README.md Outdated Show resolved Hide resolved
![Insured Bridge](./insured-bridge.png)

1. The Insurance Fund MUST store a supply of token greater than the sum of all transfer value which can flow over the bridge between during the Risk Period.
1. The Risk Period MUST reflect the time it takes for an informer to recognize the loss between the two chains and the time it takes for the Insurance Fund Governor to trigger the Insurance Fund to burn token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would put this before the previous point since it defines Risk Period

MIP/mip-50/README.md Outdated Show resolved Hide resolved

## Motivation

[MD-38](https://github.com/movementlabsxyz/MIP/pull/38) requests provisions for use of AB-FFS that enable a fixed supply of token. This MIP introduces an Insurance Fund for the bridge which can be used to cover losses. The Insurance Fund will be used to cover losses in the event of a hack or other catastrophic event and can insure a fixed supply of token is maintained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[MD-38](https://github.com/movementlabsxyz/MIP/pull/38) requests provisions for use of AB-FFS that enable a fixed supply of token. This MIP introduces an Insurance Fund for the bridge which can be used to cover losses. The Insurance Fund will be used to cover losses in the event of a hack or other catastrophic event and can insure a fixed supply of token is maintained.
[MD-38](https://github.com/movementlabsxyz/MIP/pull/38) requests provisions for use of AB-FFS that enable a fixed circulating supply of token across L1 and L2. This MIP introduces an Insurance Fund for the bridge which can be used to cover losses. The Insurance Fund will be used to cover losses in the event of a hack or other catastrophic event and can insure a fixed supply of token is maintained.

Co-authored-by: Andreas Penzkofer <[email protected]>
@l-monninger
Copy link
Contributor Author

@apenzk To you point, this MIP needs to further detail the one-sided nature of the security and why that is apt. There is indeed asynchrony between bridge operation and settlement of the L2 on the L1. This means that, without the appropriate information from the informer, you could have state where the insurance fund is activated, but the exploited amount continues to increase.

The informer must, in fact, account for these differences in time. I think it must first indicate the invariant is violated and then wait until the bridge has been restricted to a 0 rate limit to report the loss.

@apenzk
Copy link
Contributor

apenzk commented Nov 13, 2024

@apenzk To you point, this MIP needs to further detail the one-sided nature of the security and why that is apt. There is indeed asynchrony between bridge operation and settlement of the L2 on the L1. This means that, without the appropriate information from the informer, you could have state where the insurance fund is activated, but the exploited amount continues to increase.

The informer must, in fact, account for these differences in time. I think it must first indicate the invariant is violated and then wait until the bridge has been restricted to a 0 rate limit to report the loss.

@l-monninger so the proposal is to force a synchronization. This may be workable albeit it is still not clear to me what amount of discrepancy would trigger such a lock-down of the bridge (0 rate limit)

@apenzk apenzk changed the title [review] MIP-50: Insured Bridge [review] MIP-50: Insured Native Bridge Nov 18, 2024
@apenzk apenzk added the bridge label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants