generate headers in devel space instead of build space #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested & it works. |
isucan
added a commit
that referenced
this pull request
Feb 28, 2014
generate headers in devel space instead of build space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming catkin version passing absolute INCLUDE_DIRS to catkin_package() will be allowed (ros/catkin#600). But since your absolute build space path is temporary downstream packages will fail to find that folder. (Before any absolute path was ignored but there where use cases where it should be possible.)
Instead this pull request generates the header in the devel space which catkin is aware of and assumes that these generated files will be installed by the user (similar as generated message headers).
Please review and test - I haven't even tried to compile the package after the change 😉 This fix should be released in Groovy, Hydro and Indigo.