Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demo.launch.py for ros2 #64

Merged
merged 7 commits into from
May 20, 2021
Merged

Add demo.launch.py for ros2 #64

merged 7 commits into from
May 20, 2021

Conversation

vatanaksoytezer
Copy link

Most of the tutorials depends on demo.launch.py of panda_moveit_config. This PR adds this file along with rviz2 configs, so it can be used by tutorials.

@vatanaksoytezer vatanaksoytezer mentioned this pull request Apr 26, 2021
Open
This was referenced Apr 28, 2021
Open
Closed
MarqRazz
MarqRazz reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vatanaksoytezer why did the rviz configs change? Are the changes compatible with ROS1 & 2?

@vatanaksoytezer
Copy link
Author

@vatanaksoytezer why did the rviz configs change? Are the changes compatible with ROS1 & 2?

rviz configurations are not compatible between ROS1 and ROS2 so I had to make a new ROS2 config.

@MarqRazz
Copy link
Contributor

MarqRazz commented May 5, 2021

If that is the case should we delete demo.launch? I know the rest of the launch files are not working but we should probably delete the ones that have been converted.

@vatanaksoytezer
Copy link
Author

If that is the case should we delete demo.launch? I know the rest of the launch files are not working but we should probably delete the ones that have been converted.

I was questioning that myself as well. I just left it as a reference but since it is converted it makes sense to delete it. I'll delete it.

@henningkayser henningkayser merged commit 34367e6 into moveit:ros2 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarqRazz MarqRazz MarqRazz approved these changes

@henningkayser henningkayser henningkayser approved these changes

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vatanaksoytezer @MarqRazz @henningkayser