Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added camera bag file to utilize in both perception pipeline demo and moveit_middleware_benchmark #3

Merged

Conversation

CihatAltiparmak
Copy link
Member

@CihatAltiparmak CihatAltiparmak commented Aug 10, 2024

Hello, i wanted to add the bag file which it has some camera topics. I think it would be better to use this bag file for both perception pipeline demo and moveit_middleware_benchmark tool. Friendly tag here (@sjahr )

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, do you mind putting the bagfile into a new folder called something like rosbags, bagfiles etc? I think that would be cleaner. Because I'd probably do that: Don't forget to add that folder to the CMakeLists.txt install command 😉

@sjahr sjahr self-requested a review August 12, 2024 09:37
@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Aug 14, 2024

Hello,
I've applied your suggestion and tested in perception pipeline demo (it works). But just to validate, it would be super great if you test with perception pipeline. (unnecessary datas, some broken stuffs and so on)

Btw i've fixed the typo in author 😉 🆒

moveit_benchmark_resources/package.xml Outdated Show resolved Hide resolved
moveit_benchmark_resources/package.xml Show resolved Hide resolved
@sjahr sjahr merged commit 565faee into moveit:main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants