Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the displayed tutorial robot #720

Merged
merged 13 commits into from
Jul 27, 2023
Merged

Update the displayed tutorial robot #720

merged 13 commits into from
Jul 27, 2023

Conversation

abake48
Copy link
Contributor

@abake48 abake48 commented Jul 26, 2023

Description

This PR starts the transition to make the displayed robot be the Kinova Gen3 7dof. This coincides with the release of the public ROS 2 driver for the Kinova Gen3 arms.

Due to time constraints, this PR only updates the tutorial section of the docs, excluding the Pick and Place with MoveIt Task Constructor tutorial which will be updated in a follow PR.

To ease the transition from the Panda arm, the Panda tutorial example code has only been renamed, not removed, so users can still reference them if they pull down the repo.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First superficial pass through GitHub web UI: looks really good so far.
Only more obvious complaint is that all media files have significantly increased in size. Maybe not a huge deal since they are still relatively small.

I'll test this locally before giving the green check mark.

package.xml Show resolved Hide resolved
doc/tutorials/your_first_project/panda_hello_moveit.cpp Outdated Show resolved Hide resolved
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built locally and tried these tutorials, they seem to work for me.

@abake48 abake48 merged commit f226955 into moveit:main Jul 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants