Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

[Dwarf] New language name for Move #1080

Open
ksolana opened this issue Oct 21, 2023 · 9 comments
Open

[Dwarf] New language name for Move #1080

ksolana opened this issue Oct 21, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@ksolana
Copy link
Contributor

ksolana commented Oct 21, 2023

As move->llvm compiler is in the works. There is a need to have Dwarf attribute supporting move programming language.

As per https://dwarfstd.org/languages.html: "Between revisions of the Standard, new language codes may be requested by submitting a request on the Public Comment page."

It can be based on a recent request by Mojo: https://dwarfstd.org/issues/230502.1.html

@ksolana ksolana added the enhancement New feature or request label Oct 21, 2023
@ksolana
Copy link
Contributor Author

ksolana commented Oct 21, 2023

@jcivlin FYI

@wrwg
Copy link
Member

wrwg commented Oct 21, 2023

Sounds like a great idea. We discuss at the next Move community meeting, I think you, Mysten, Aptos and other can co-sign this. I can work on the form after we discussed.

@sblackshear

@jcivlin
Copy link

jcivlin commented Nov 2, 2023

We need a new value LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove likewise llvm to support and generate Dwarf info for all Move language constructs.

@wrwg
Copy link
Member

wrwg commented Nov 2, 2023

We need a new value LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove likewise llvm to support and generate Dwarf info for all Move language constructs.

Can you link to/quickly describe whats the difference, meaning wise and process wise? Can we get both with one request?

@ksolana
Copy link
Contributor Author

ksolana commented Nov 3, 2023

There are two steps

  1. Email dwardstd https://dwarfstd.org/languages.html as mentioned in the issue description.
  2. Once that is approved, put a patch to llvm-project with an entry like LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove

1 needs to happen first. But we can do the changes in our internal llvm fork with second part to make progress.

@ksolana
Copy link
Contributor Author

ksolana commented Nov 14, 2023 via email

@sausagee sausagee self-assigned this Dec 1, 2023
@wrwg
Copy link
Member

wrwg commented Jan 26, 2024

Looks like we dropped the ball on this. Is it still a thing?

@ksolana
Copy link
Contributor Author

ksolana commented Jan 27, 2024

Yeah, we are expecting the move language designers to propose this to the DWARF committee.

@ksolana
Copy link
Contributor Author

ksolana commented Feb 12, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants