Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for certain packages #1121

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

anzelpwj
Copy link
Contributor

@anzelpwj anzelpwj commented Sep 5, 2024

Due to some packages found in security review, incrementing these packages in requirements.txt.

@anzelpwj
Copy link
Contributor Author

anzelpwj commented Sep 5, 2024

Note with mysql-connector-python at 8.3.0 we lose connectivity to older mysql versions (5.5 and 5.6, but we do keep 5.7) but does get official support for Python 3.12. See https://dev.mysql.com/doc/connector-python/en/connector-python-versions.html.

OTOH, 5.5 and 5.6 have been beyond end-of-life for a few years now (https://en.wikipedia.org/wiki/MySQL#Release_history). Even 5.7 is past its support window.

@anzelpwj
Copy link
Contributor Author

anzelpwj commented Sep 5, 2024

@bmos
Copy link
Contributor

bmos commented Sep 6, 2024

As it says in the logs, INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance.

You probably just need to set google-api-core to a specific version or update some other packages that depend on it.

@bmos
Copy link
Contributor

bmos commented Sep 6, 2024

I'm also looking at updating the circleci workflow so that it uses uv which should help avoid timeouts during package resolution because this workflow has now taken 46+ minutes to complete and that's ridiculous.
#1122

@anzelpwj
Copy link
Contributor Author

anzelpwj commented Sep 6, 2024

Sounds good @bmos - I tried pinning the google-api-core and it went ~30 minutes fussing around before timing out again. I'll await your PR getting merged in.

@bmos
Copy link
Contributor

bmos commented Sep 6, 2024

It might also be good to post about these in the Slack if you are there.

@shaunagm shaunagm added the breaking change applied only to PRs, indicates when something has a breaking change to be flagged in release notes label Sep 6, 2024
@shaunagm
Copy link
Collaborator

shaunagm commented Sep 6, 2024

Here's the error I see on the docs-build, during the install dependencies step:
Screenshot from 2024-09-06 11-52-51

@bmos
Copy link
Contributor

bmos commented Sep 6, 2024

curlify 2.2.1 will probably solve that as it removes ">= 3" shlex version (which does not exist)

@anzelpwj
Copy link
Contributor Author

anzelpwj commented Sep 6, 2024

I'll cut out the mysql upgrade for now so this isn't a breaking change. Will also pin curlify. Will that fix things? Guess we'll find out.

@anzelpwj
Copy link
Contributor Author

anzelpwj commented Sep 6, 2024

Issue for upgrading mysql-connector-python: #1125

@shaunagm shaunagm merged commit 009647c into move-coop:main Sep 6, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change applied only to PRs, indicates when something has a breaking change to be flagged in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants