Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GZIP on BigQuery extract to GCS #1110

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

austinweisgrau
Copy link
Collaborator

No description provided.

@shaunagm
Copy link
Collaborator

shaunagm commented Aug 27, 2024

@KasiaHinkson @IanRFerguson and/or @sharinetmc: this should take like a minute to review, if you're up for it. (If not, no worries - I trust that @austinweisgrau has written and tested good code and this does in fact Look Good To Me, but it would be nice to have a reviewer that actually uses BigQuery.)

Copy link
Contributor

@KasiaHinkson KasiaHinkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks good to me, shouldn't break anything!

@shaunagm
Copy link
Collaborator

Great, thanks @KasiaHinkson! I'll go ahead and merge this.

@shaunagm shaunagm merged commit 73754f1 into move-coop:main Aug 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants