Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Bad quality threshold is !' #10

Open
moskalenko opened this issue Jun 19, 2018 · 1 comment
Open

'Bad quality threshold is !' #10

moskalenko opened this issue Jun 19, 2018 · 1 comment

Comments

@moskalenko
Copy link

When the example is run there is a warning 'Bad quality threshold is !'. Looking at the code it comes from

main.cpp:365: fprintf( stderr, "Bad quality threshold is %c\n", badQualityThreshold ) ;

so it looks like badQualityThreshold is not calculated in GetBadQuality even for sample data.

@mourisl
Copy link
Owner

mourisl commented Jun 20, 2018

Thanks for this suggestion. Using integer though resolves this issue, but the acsii code for the quality score is not straightforward. So I add a single-quotation signs around the quality score. Hope this would make the message clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants