chore: gnoclient updates from gnomobile for PR #1047 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
…fy if the password unlocks the account Signed-off-by: Jeff Thompson <[email protected]>
…Address, not string Signed-off-by: Jeff Thompson <[email protected]>
moul
approved these changes
Nov 23, 2023
trafico-bot
bot
added
✅ Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work on GnoMobile, we made a copy of gnoclient from the PR and made some changes. This is a "PR against the PR" with the changes. It has three commits:
RenderandQEval. Also fix a small copy/paste typo in the error string for QueryAppVersion.Validatehad a comment "TODO: Also verify if the password unlocks the account." This implements to verify if the password unlocks the account by signing a blank transaction. Please see issue Validate password by signing a blank transaction. Good idea? gnolang/gno#1324 for more details.QueryAccountparameteraddrshould becrypto.Addressbecause this is how it is stored in thekeys.Infostruct . This also checks and returnsUnknownAddressError.