Add python3.10 support #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfocko
pushed a commit
to mfocko/dashboard
that referenced
this pull request
May 9, 2022
updates: - [github.com/psf/black: 22.1.0 → 22.3.0](psf/black@22.1.0...22.3.0) - [github.com/pre-commit/mirrors-prettier: v2.5.1 → v2.6.2](pre-commit/mirrors-prettier@v2.5.1...v2.6.2) - [github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.2.0](pre-commit/pre-commit-hooks@v4.1.0...v4.2.0) - [github.com/pre-commit/mirrors-mypy: v0.931 → v0.950](pre-commit/mirrors-mypy@v0.931...v0.950) - [github.com/packit/pre-commit-hooks: 1da916777f5cc26ecf221b15e58ca51891d26d94 → 3bf9afc5ede12a4ee26e9451f306edf255749396](packit/pre-commit-hooks@1da9167...3bf9afc) @mfocko: disabled jinjalint, since upstream is dead (PR with fix is open since February without any reaction from the maintainers): motet-a/jinjalint#33 Signed-off-by: Matej Focko <[email protected]>
dekoza
reviewed
Oct 6, 2022
Comment on lines
+1
to
+2
| import collections.abc | ||
| collections = collections.abc |
There was a problem hiding this comment.
This should be from collections.abc import Iterable and then change line 9 to if (isinstance(el, Iterable) and
|
@aneustroev any way to make progress on this one please? Otherwise @dekoza would you accept/review another PR to fix it please? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.