Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursively expands ${VARIABLES} within the value #40

Closed
wants to merge 1 commit into from

Conversation

apm
Copy link

@apm apm commented Dec 21, 2014

Fixes #39

@maxbeatty
Copy link
Contributor

any way to add this without reorganizing the whole module? 😸

@apm
Copy link
Author

apm commented Dec 22, 2014

Yeah, that was a bit rude, but the original has a function called dotenv that returns an object named dotenv. Not a fan of that. It is interesting it works since the inner dotenv is not declared.

@jcblw
Copy link
Collaborator

jcblw commented Dec 23, 2014

I do think the refactor is logical, but I would love to see the addition of this feature without it. Then maybe another pull request with the refactor. I just don't like that we essentially need to look over then entire modules code to code review the addition of a feature.

@apm
Copy link
Author

apm commented Dec 23, 2014

Sure, I'll submit a new one with a proper diff.

@apm apm closed this Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable expansion only works when it matches the entire value
3 participants