-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress error messages by default #154
Conversation
1 similar comment
1 similar comment
I agree that this should be turned off by default. |
@maxbeatty are there any reasons to drop support for older versions of Node? |
Nothing significant is changing about the implementation that would prevent it from working, but those older versions are no longer receiving updates like security patches so I think it's better for the community at large to go forward. If you're using a sane semver range, you won't notice this. |
Based on the table here, I would suggest leaving 0.12 support and opening a separate issue/PR for dropping support for it in Dec/Jan. That seems to be the timeline for ending critical patches to it. |
@maxbeatty @motdotla we looking to do a major bump with this? If so and you guys think #158 is cool we should probably get that in the bump as well. |
yes, should be a major version release because of the breaking change to the silent option |
logging errors by default is scaring more people than it's helping. see #135 and this travis output as examples
this should result in a major release