Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress error messages by default #154

Merged
merged 4 commits into from
Dec 9, 2016
Merged

suppress error messages by default #154

merged 4 commits into from
Dec 9, 2016

Conversation

maxbeatty
Copy link
Contributor

logging errors by default is scaring more people than it's helping. see #135 and this travis output as examples

this should result in a major release

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3c89132 on better-err-msg into 6349be8 on master.

@coveralls
Copy link

coveralls commented Oct 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling b84ed61 on better-err-msg into 6349be8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c40b5d7 on better-err-msg into 6349be8 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c40b5d7 on better-err-msg into 6349be8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3485a23 on better-err-msg into 6349be8 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3485a23 on better-err-msg into 6349be8 on master.

@maxbeatty
Copy link
Contributor Author

@motdotla @jcblw do you agree logging the errors is doing more harm than good?

@jcblw
Copy link
Collaborator

jcblw commented Oct 19, 2016

I agree that this should be turned off by default.

@heitortsergent
Copy link

@maxbeatty are there any reasons to drop support for older versions of Node?

@maxbeatty
Copy link
Contributor Author

Nothing significant is changing about the implementation that would prevent it from working, but those older versions are no longer receiving updates like security patches so I think it's better for the community at large to go forward. If you're using a sane semver range, you won't notice this.

@heitortsergent
Copy link

Based on the table here, I would suggest leaving 0.12 support and opening a separate issue/PR for dropping support for it in Dec/Jan. That seems to be the timeline for ending critical patches to it.

@jcblw
Copy link
Collaborator

jcblw commented Nov 27, 2016

@maxbeatty @motdotla we looking to do a major bump with this? If so and you guys think #158 is cool we should probably get that in the bump as well.

@maxbeatty
Copy link
Contributor Author

yes, should be a major version release because of the breaking change to the silent option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants