Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original error in reader #289

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

davidgomesdev
Copy link
Contributor

Previously, when the reader fails to consume a message, the only error shown is "Unable to read messages" with the original error as nil.

Now the error is kept in the log.

Note: the previous PR was auto-closed due to having renamed the branch.

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution! 🙏

I'll release a patch version soon after merging this.

@mostafa mostafa merged commit 1d8e9ef into mostafa:main Apr 30, 2024
3 checks passed
@davidgomesdev davidgomesdev deleted the keep-error-in-consume branch April 30, 2024 15:58
@mostafa
Copy link
Owner

mostafa commented Apr 30, 2024

@davidgomesdev Released in v0.25.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants