Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dot to underscore in metrics separator to be compatible with prometheus metrics #177

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

rgordill
Copy link
Contributor

Fixes #176.

@mostafa
Copy link
Owner

mostafa commented Nov 21, 2022

Hey @rgordill,

Thanks for your contribution. I see some test scripts failing, mainly because of metric name usage in thresholds. Please update those as well.

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rgordill
Copy link
Contributor Author

Hey @rgordill,

Thanks for your contribution. I see some test scripts failing, mainly because of metric name usage in thresholds. Please update those as well.

Changed and forced pull to rerun the tests.

@mostafa
Copy link
Owner

mostafa commented Nov 21, 2022

@rgordill Thanks for the fix.
Would you please fix the formatting of the script files with prettier? I'll fix that.

Thanks for your contribution!

@mostafa mostafa merged commit 120d70d into mostafa:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus metrics are not compatible with "dots"
2 participants