Consolidate most examples data into a YAML file #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames all the
examples/compile/out/*.txt
files toexamples/*.js
so that GitHub and editors syntax-highlight them, and moves the rest of the output data to a single file calledtests/goldenfiles/examples.yml
. This reduces verbosity and will make it easier to add new types of data, such as the list of CLI args to pass to each example.As mentioned in the comments in
tests/cli.rs
, I wrote a custom YAML serializer for this file because yaml-rust does not currently support emitting literal scalars:However, I still use that library (through serde_yaml) to parse the generated file and thus ensure that my custom serializer works correctly (at least, in the single case where it is used).