Utility: use Corrade String and StringView in ConfigurationValue #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we discussed in mosra/corrade#146, I merged a part of this as 8b45a51. Thank you! Leaving the PR open, will merge the rest when I get to cleaning up STL usage in |
|
Thanks so much ! Yeah, the rest doesn't matter too much for us as it doesn't affect compile times, so, I don't mind, you can even close it hehe |
|
It matters for me ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
We're trying to optimize our compile times and I noticed that StlForwardString.h is actually very heavy on MSVC because it just directly includes , so I thought let's go and try to clean this up.
Let me know if I'm going at this correctly 😅
Associated Corrade PR: mosra/corrade#146