Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in-memory pubsub component #329

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

zach030
Copy link
Contributor

@zach030 zach030 commented Nov 23, 2021

What this PR does:
Add in-memory pubsub component and demo client

Which issue(s) this PR fixes:

Fixes #67

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #329 (1a22d40) into main (fd12855) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a22d40 differs from pull request most recent head 4848d3a. Consider uploading reports for the commit 4848d3a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files          48       48           
  Lines        2100     2100           
=======================================
  Hits         1195     1195           
  Misses        774      774           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd12855...4848d3a. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood
Copy link
Member

Thanks for your contribution!
I will try to contribute the in-memory state store component to dapr

@seeflood seeflood merged commit e2dc2c0 into mosn:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users run our demo without go environment
2 participants