Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to control if a phase can be run synchronously #800

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

spacewander
Copy link
Member

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 89.86301% with 37 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (bede870) to head (d5555ce).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
api/pkg/filtermanager/filtermanager.go 89.96% 20 Missing and 13 partials ⚠️
api/pkg/filtermanager/api/phase.go 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
- Coverage   87.24%   87.06%   -0.19%     
==========================================
  Files         143      144       +1     
  Lines        8563     8696     +133     
==========================================
+ Hits         7471     7571     +100     
- Misses        851      875      +24     
- Partials      241      250       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@spacewander spacewander marked this pull request as ready for review November 18, 2024 06:14
@spacewander spacewander marked this pull request as draft November 18, 2024 08:30
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
@spacewander spacewander merged commit 0eac2c0 into main Nov 19, 2024
18 checks passed
@spacewander spacewander deleted the 1118 branch November 19, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant