Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporter interface: used filename instead of byte slice #96

Closed
doujiang24 opened this issue May 13, 2022 · 3 comments
Closed

reporter interface: used filename instead of byte slice #96

doujiang24 opened this issue May 13, 2022 · 3 comments
Assignees
@songzhibin97

Comments

@doujiang24
Copy link
Member

filename is more flexible, people can read bytes from the file, or just report the filename.

it's a breaking change, but I think it's worthing.
@doujiang24
Copy link
Member Author

related code: https://github.com/mosn/holmes/blob/master/holmes.go#L75

@songzhibin97
Copy link
Member

Modify the interface or add a parameter, is that what you mean?

@doujiang24
Copy link
Member Author

@songzhibin97 I think changing the current interface is better.

doujiang24 pushed a commit that referenced this issue May 19, 2022
@songzhibin97
change: reporter interface: use filename instead of byte slice, #96 (#98
5b19423 
)

using filename is more flexible, people can read bytes from the file, or just report the filename.
it's a breaking change, but it's still worthing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songzhibin97 songzhibin97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doujiang24 @songzhibin97