feat: upgrade standard to v17

README.md

@@ -107,7 +107,7 @@ Brokers that support the [Bridge Protocol][bridge_protocol] can connect to
 Aedes.  When connecting with this special protocol, subscriptions work as usual
 except that the `retain` flag in the packet is propagated as-is.
 
-## Exensions
+## Extensions
 
 - [aedes-logging]: Logging module for Aedes, based on Pino
 - [aedes-stats]: Stats for Aedes

docs/Aedes.md

@@ -186,7 +186,7 @@ const server = require('net').createServer(aedes.handle)
 
 Directly subscribe a `topic` in server side. Bypass [`authorizeSubscribe`](#handler-authorizesubscribe-client-subscription-callback)
 
-The `topic` and `deliverfunc` is a compound key to differentiate the uniqueness of its subscription pool. `topic` could be the one that is existed, in this case `deliverfunc` will be invoked as well as `SUBSCRIBE` does.
+The `topic` and `deliverfunc` is a compound key to differentiate the uniqueness of its subscription pool. `topic` could be the one that is existed, in this case `deliverfunc` will be invoked as well as [`SUBSCRIBE`][SUBSCRIBE] does.
 
 `deliverfunc` supports backpressue.
 
@@ -337,7 +337,7 @@ function defaultAuthorizePublish (client, packet, callback) {
 Invoked when
 
 1. restore subscriptions in non-clean session.
-2. incoming client `SUBSCRIBE`
+2. incoming client [`SUBSCRIBE`][SUBSCRIBE]
 
 `subscription` is a dictionary object like `{ topic: hello, qos: 0 }`.
 

lib/handlers/connect.js

@@ -70,7 +70,7 @@ function init (client, packet, done) {
     const error = new Error(errorMessages[returnCode])
     error.errorCode = returnCode
     doConnack(
-      { client: client, returnCode: returnCode, sessionPresent: false },
+      { client, returnCode, sessionPresent: false },
       done.bind(this, error))
     return
   }
@@ -156,8 +156,8 @@ function fetchSubs (arg, done) {
   if (!this.packet.clean) {
     client.broker.persistence.subscriptionsByClient({
       id: client.id,
-      done: done,
-      arg: arg
+      done,
+      arg
     }, gotSubs)
     return
   }

lib/handlers/subscribe.js

@@ -217,7 +217,7 @@ function completeSubscribe (err) {
     topic: $SYS_PREFIX + broker.id + '/new/subscribes',
     payload: Buffer.from(JSON.stringify({
       clientId: client.id,
-      subs: subs
+      subs
     }), 'utf8')
   }, noop)
 

package.json

@@ -104,14 +104,14 @@
     "concat-stream": "^2.0.0",
     "duplexify": "^4.1.2",
     "license-checker": "^25.0.1",
-    "markdownlint-cli": "^0.31.1",
+    "markdownlint-cli": "^0.32.1",
     "mqtt": "^4.3.7",
     "mqtt-connection": "^4.1.0",
     "pre-commit": "^1.2.2",
     "proxyquire": "^2.1.3",
     "release-it": "^15.1.2",
     "snazzy": "^9.0.0",
-    "standard": "^16.0.4",
+    "standard": "^17.0.0",
     "tap": "^16.0.1",
     "tsd": "^0.22.0",
     "typescript": "^4.6.3",

test/connect.js

@@ -214,13 +214,13 @@ test('client connect clear outgoing', function (t) {
   const broker = aedes({ id: brokerId })
   t.teardown(broker.close.bind(broker))
 
-  const subs = [{ clientId: clientId }]
+  const subs = [{ clientId }]
   const packet = {
     cmd: 'publish',
     topic: 'hello',
     payload: Buffer.from('world'),
     qos: 1,
-    brokerId: brokerId,
+    brokerId,
     brokerCounter: 2,
     retain: true,
     messageId: 42,
@@ -235,7 +235,7 @@ test('client connect clear outgoing', function (t) {
       protocolId: 'MQTT',
       protocolVersion: 4,
       clean: true,
-      clientId: clientId,
+      clientId,
       keepalive: 0
     })
 
@@ -705,7 +705,7 @@ test('websocket clients have access to the request object', function (t) {
 
   const server = http.createServer()
   ws.createServer({
-    server: server
+    server
   }, broker.handle)
 
   server.listen(port, function (err) {

test/events.js

@@ -161,7 +161,7 @@ test('Test backpressure aedes published function', function (t) {
 
   server.listen(0, function () {
     const port = server.address().port
-    publisher = mqtt.connect({ port: port, host: 'localhost', clean: true, keepalive: 30 })
+    publisher = mqtt.connect({ port, host: 'localhost', clean: true, keepalive: 30 })
 
     function next () {
       if (--publishCount > 0) { process.nextTick(publish) }

test/helper.js

@@ -19,10 +19,10 @@ function setup (broker) {
 
   return {
     client: broker.handle(conn),
-    conn: conn,
-    inStream: inStream,
-    outStream: outStream,
-    broker: broker
+    conn,
+    inStream,
+    outStream,
+    broker
   }
 }
 
@@ -74,8 +74,8 @@ function subscribe (t, subscriber, topic, qos, done) {
     cmd: 'subscribe',
     messageId: 24,
     subscriptions: [{
-      topic: topic,
-      qos: qos
+      topic,
+      qos
     }]
   })
 
@@ -110,10 +110,10 @@ function subscribeMultiple (t, subscriber, subs, expectedGranted, done) {
 }
 
 module.exports = {
-  setup: setup,
-  connect: connect,
-  noError: noError,
-  subscribe: subscribe,
-  subscribeMultiple: subscribeMultiple,
+  setup,
+  connect,
+  noError,
+  subscribe,
+  subscribeMultiple,
   delay: util.promisify(setTimeout)
 }

test/meta.js

@@ -307,7 +307,7 @@ test('connect and connackSent event', { timeout: 50 }, function (t) {
     protocolId: 'MQTT',
     protocolVersion: 4,
     clean: true,
-    clientId: clientId,
+    clientId,
     keepalive: 0
   })
 

test/not-blocking.js

@@ -42,7 +42,7 @@ test('connect 500 concurrent clients', function (t) {
 
     for (let i = 0; i < total; i++) {
       clients[i] = mqtt.connect({
-        port: port,
+        port,
         keepalive: 0,
         reconnectPeriod: 100
       }).on('connect', function () {
@@ -79,7 +79,7 @@ test('do not block after a subscription', function (t) {
     const port = server.address().port
 
     const publisher = mqtt.connect({
-      port: port,
+      port,
       keepalive: 0
     }).on('error', function (err) {
       clock.clearTimeout(clockId)
@@ -103,7 +103,7 @@ test('do not block after a subscription', function (t) {
 
     function startSubscriber () {
       subscriber = mqtt.connect({
-        port: port,
+        port,
         keepalive: 0
       }).on('error', function (err) {
         clock.clearTimeout(clockId)
@@ -163,7 +163,7 @@ test('do not block with overlapping subscription', function (t) {
     const port = server.address().port
 
     const publisher = mqtt.connect({
-      port: port,
+      port,
       keepalive: 0
     }).on('error', function (err) {
       clock.clearTimeout(clockId)
@@ -187,7 +187,7 @@ test('do not block with overlapping subscription', function (t) {
 
     function startSubscriber () {
       subscriber = mqtt.connect({
-        port: port,
+        port,
         keepalive: 0
       }).on('error', function (err) {
         clock.clearTimeout(clockId)

test/topics.js

@@ -108,7 +108,7 @@ test('publish invalid topic with +', function (t) {
       cmd: 'subscribe',
       messageId: 24,
       subscriptions: [{
-        topic: topic,
+        topic,
         qos: 0
       }]
     })
@@ -157,7 +157,7 @@ test('topics are case-sensitive', function (t) {
     ;['hello', 'HELLO', 'heLLo', 'HELLO/#', 'hello/+'].forEach(function (topic) {
       publisher.inStream.write({
         cmd: 'publish',
-        topic: topic,
+        topic,
         payload: 'world',
         qos: 0,
         retain: false
@@ -171,7 +171,7 @@ function subscribeMultipleTopics (t, broker, qos, subscriber, subscriptions, don
   subscriber.inStream.write({
     cmd: 'subscribe',
     messageId: 24,
-    subscriptions: subscriptions
+    subscriptions
   })
 
   subscriber.outStream.once('data', function (packet) {
@@ -183,7 +183,7 @@ function subscribeMultipleTopics (t, broker, qos, subscriber, subscriptions, don
       cmd: 'publish',
       topic: 'hello/world',
       payload: 'world',
-      qos: qos,
+      qos,
       messageId: 42
     })
 

test/will.js

@@ -90,7 +90,7 @@ test('delivers old will in case of a crash', function (t) {
 
     const interval = 10 // ms, so that the will check happens fast!
     const broker = aedes({
-      persistence: persistence,
+      persistence,
       heartbeatInterval: interval
     })
     t.teardown(broker.close.bind(broker))
@@ -121,7 +121,7 @@ test('delete old broker', function (t) {
 
   const heartbeatInterval = 100
   const broker = aedes({
-    heartbeatInterval: heartbeatInterval
+    heartbeatInterval
   })
   t.teardown(broker.close.bind(broker))
 
@@ -421,7 +421,7 @@ test('don\'t delivers a will if broker alive', function (t) {
     t.error(err, 'no error')
 
     const opts = {
-      persistence: persistence,
+      persistence,
       heartbeatInterval: 10
     }
 
@@ -472,7 +472,7 @@ test('handle will publish error', function (t) {
     t.error(err, 'no error')
 
     const opts = {
-      persistence: persistence,
+      persistence,
       heartbeatInterval: 10
     }
 
@@ -509,7 +509,7 @@ test('handle will publish error 2', function (t) {
     t.error(err, 'no error')
 
     const opts = {
-      persistence: persistence,
+      persistence,
       heartbeatInterval: 10
     }