New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop bulk-write-stream #731

Merged

gnought merged 1 commit into main from feat/drop-bulk-write-stream

Apr 19, 2022

Collaborator

gnought commented Apr 19, 2022

This aims to reduce one dependency.
Hope I implement well for writev function


          drop bulk-write-stream

796ab49

gnought requested review from mcollina and robertsLando

April 19, 2022 05:20

coveralls commented Apr 19, 2022

Pull Request Test Coverage Report for Build 2187668459

0 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.0e**-05%**) to 99.911%

Totals
Change from base Build 2179826039:	8.0e-05%
Covered Lines:	803
Relevant Lines:	803

💛 - Coveralls

coveralls commented Apr 19, 2022

Pull Request Test Coverage Report for Build 2187668459

4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.0e**-05%**) to 99.911%

Totals
Change from base Build 2179826039:	8.0e-05%
Covered Lines:	803
Relevant Lines:	803

💛 - Coveralls

robertsLando approved these changes

View reviewed changes

mcollina approved these changes

View reviewed changes

Collaborator

mcollina left a comment

lgtm

robertsLando changed the title ~~drop bulk-write-stream~~ chore: drop bulk-write-stream

gnought merged commit 0786082 into main

gnought deleted the feat/drop-bulk-write-stream branch

April 19, 2022 10:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet