Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #583, the fix is valid but the unit test does not. The test is still pass when we revert the line back to
The PR mentioned Aedes uses through2 and suffers similar bugs. The claim is partially correct. We need to do a fix but it is due to the nodejs Transform callback behaviour, in our case it is
writeCallback
call. We could refer to nodejs doc https://nodejs.org/docs/latest-v16.x/api/stream.html#transform_transformchunk-encoding-callbackThis PR is to fix the unit test on PR #583.