Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish to $SYS/ not allowed to prevent DoS #622

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Apr 21, 2021

Fixes #597

Is this a breaking change in your opinion? @mcollina

@coveralls
Copy link

coveralls commented Apr 21, 2021

Pull Request Test Coverage Report for Build 770689628

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.911%

Totals Coverage Status
Change from base Build 763934071: 0.001%
Covered Lines: 800
Relevant Lines: 800

💛 - Coveralls

@robertsLando
Copy link
Member Author

@mcollina Ping?

Copy link
Collaborator

@GavinDmello GavinDmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@robertsLando robertsLando merged commit 353e0f8 into main Apr 22, 2021
@robertsLando robertsLando deleted the fix#597 branch April 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] DoS Possibility if Client ID is known (Security)
3 participants