Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance not-blocking test for new MQTT.js behaviour #608

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Apr 5, 2021

No description provided.

@gnought gnought requested review from robertsLando and mcollina April 5, 2021 14:00
@coveralls
Copy link

coveralls commented Apr 5, 2021

Pull Request Test Coverage Report for Build 719390042

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.554%

Totals Coverage Status
Change from base Build 689232499: 0.0%
Covered Lines: 800
Relevant Lines: 801

💛 - Coveralls

@gnought gnought force-pushed the bugfix/enhance_test branch from b6f0c7c to dc389f6 Compare April 6, 2021 05:07
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title Enhance not-blocking test for new MQTT.js behaviour chore: enhance not-blocking test for new MQTT.js behaviour Apr 6, 2021
@robertsLando robertsLando merged commit bc961a4 into master Apr 6, 2021
@robertsLando robertsLando deleted the bugfix/enhance_test branch April 6, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants