Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps and fixed tests #479

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Bump deps and fixed tests #479

merged 5 commits into from
Apr 29, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Apr 29, 2020

@mcollina

I don't know if this was wanted or no. In [email protected] the only stream error thrown was 'ECONNREFUSED' but in [email protected] now it throws all this errors:

var socketErrors = [
  'ECONNREFUSED',
  'EADDRINUSE',
  'ECONNRESET',
  'ENOTFOUND'
]

Source: https://github.com/mqttjs/MQTT.js/pull/1076/files#diff-50cfa59973c04321b5da0c6da0fdf4feR30

Here you see the commit that has changed this: https://github.com/mqttjs/MQTT.js/pull/1076/files#diff-50cfa59973c04321b5da0c6da0fdf4feL325

@github-actions
Copy link

Pull Request Test Coverage Report for Build 90973369

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.724%

Totals Coverage Status
Change from base Build 90900640: 0.0%
Covered Lines: 775
Relevant Lines: 775

💛 - Coveralls

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@robertsLando
Copy link
Member Author

robertsLando commented Apr 29, 2020

About your LGTM @mcollina, I don't understand if the answer to my question

I don't know if this was wanted or no. In [email protected] the only stream error thrown was 'ECONNREFUSED' but in [email protected] now it throws all this errors:

Is yes it is wanted or not it should not work like that. The connection is closed and I think that that error should not be thrown by the client. The stream has been closed correctly

@mcollina
Copy link
Collaborator

tests are passing and code is ok for me. I didn’t understand your question.

@robertsLando
Copy link
Member Author

@mcollina I don't think mqtt client should throw that error when closing client. That's why my question

I think that once the stream is closed using client end there should be no error thrown by the stream

@mcollina
Copy link
Collaborator

I don’t know and it does not matter for Aedes. There are a few new folks that are working on MQTT.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants