Add 'delivered' event on PUBACK handler #39
Conversation
|
Can you please do the same for PUBCOM and add the doc relative to this in the README? |
|
Right now, the I changed the event to 'deliver' and updated the test. Working on updates to README now. |
|
README updated. Let me know if there is anything else to add. |
| client.publish({ | ||
| topic: 'hello', | ||
| payload: new Buffer('world'), | ||
| qos: 1 |
Add 'delivered' event on PUBACK handler
|
Release as v0.14.0 |
| @@ -3,6 +3,7 @@ | |||
| function handlePuback (client, packet, done) { | |||
| var persistence = client.broker.persistence | |||
| persistence.outgoingClearMessageId(client, packet, done) | |||
| client.broker.emit('deliver', packet, client) | |||
There was a problem hiding this comment.
I believe delivered or ack could be a better name, in Mosca we are using delivered @mcollina
There was a problem hiding this comment.
I think 'ack' is the best of all, actually. I'll get that updated asap!
Il giorno dom 3 apr 2016 alle 18:14 Behrad [email protected] ha
scritto:
In lib/handlers/puback.js
#39 (comment):@@ -3,6 +3,7 @@
function handlePuback (client, packet, done) {
var persistence = client.broker.persistence
persistence.outgoingClearMessageId(client, packet, done)
- client.broker.emit('deliver', packet, client)
I believe delivered or ack could be a better name, in Mosca we are using
delivered @mcollina https://github.com/mcollina—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mcollina/aedes/pull/39/files/7897baca0c9db516cd179f3d64497c9527b84f5a#r58312605
This addresses #10 and emits a
deliveredevent when a PUBACK is received.