Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Memory leak on client.js 'connected' event #348 #362

Merged
merged 17 commits into from
Jan 28, 2020
Merged

fix: Memory leak on client.js 'connected' event #348 #362

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
89329c3
fix: Memory leak on client.js 'connected' event #348
robertsLando Jan 23, 2020
ebbec2f
fix: Test for connect memory leak
robertsLando Jan 23, 2020
2d833a9
fix: Removed typo
robertsLando Jan 23, 2020
f974d4f
fix: Replaced timout with connected event
robertsLando Jan 23, 2020
d6bb864
fix: Clean up code
robertsLando Jan 23, 2020
f9fed52
fix: Removed shift
robertsLando Jan 23, 2020
95efe31
refactor: Code improvments
robertsLando Jan 23, 2020
7683bec
fix: Detect memory leaks
robertsLando Jan 23, 2020
517eb86
fix: Free queue on client close
robertsLando Jan 24, 2020
a486cfd
feat: Queue limit
robertsLando Jan 24, 2020
6b72608
docs: Updated interface and docs about queueLimit
robertsLando Jan 24, 2020
fad8e18
fix: Typo
robertsLando Jan 24, 2020
5f639f0
docs: contributing
robertsLando Jan 24, 2020
ef52695
fix: code refactoring
robertsLando Jan 28, 2020
bae627e
fix: Removed unused 'nextBach' call in client #363
robertsLando Jan 28, 2020
ada952a
Merge https://github.com/mcollina/aedes into fix#348
robertsLando Jan 28, 2020
3bdd9af
refactor: code formatting
robertsLando Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ function Client (broker, conn, req) {

this.connDetails = null
robertsLando marked this conversation as resolved.
Show resolved Hide resolved

// queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event
this.parser._queue = []

this.on('connected', () => {
robertsLando marked this conversation as resolved.
Show resolved Hide resolved
while (this.parser._queue.length > 0) {
handle(this, this.parser._queue.shift(), this._nextBatch)
}
robertsLando marked this conversation as resolved.
Show resolved Hide resolved
})
robertsLando marked this conversation as resolved.
Show resolved Hide resolved

this.parser.on('packet', enqueue)

function nextBatch (err) {
Expand Down Expand Up @@ -330,9 +339,7 @@ function enqueue (packet) {
if (client.connackSent || client._parsingBatch === 1) {
handle(client, packet, client._nextBatch)
} else {
client.on('connected', () => {
handle(client, packet, client._nextBatch)
})
this._queue.push(packet)
}
}

Expand Down