Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe subscriptions #313

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Dedupe subscriptions #313

merged 3 commits into from
Sep 2, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Sep 1, 2019

If there are duplicated topics in subscriptions, no matter what QoS is, we pick the last one.
say the subscriptions in SUBSCRIBE are

[{ topic: 'hello', qos: 1 }, { topic: 'hello', qos: 0 }]

the actual subscription is only { topic: 'hello', qos: 0 }

Vernemq and mosquitto are in same behaviour.

@gnought gnought added the bug label Sep 1, 2019
mcollina
mcollina reviewed Sep 2, 2019
View reviewed changes
lib/handlers/subscribe.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Sep 2, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 81e75ac into moscajs:master Sep 2, 2019
@gnought gnought deleted the hotfix/dedupe_sub branch September 2, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnought @mcollina