Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block $ prefix topic in subscriptions #312

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Block $ prefix topic in subscriptions #312

merged 1 commit into from
Aug 30, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Aug 30, 2019

The Server MUST NOT match Topic Filters starting with a wildcard character (# or +) with Topic Names beginning with a $ character [MQTT-4.7.2-1]

@gnought gnought added the bug label Aug 30, 2019
mcollina
mcollina approved these changes Aug 30, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit bc7f768 into moscajs:master Aug 30, 2019
@gnought gnought deleted the hotfix/block_dollar_prefix_topic_in_sub branch August 31, 2019 04:15
@robertsLando robertsLando mentioned this pull request Jan 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnought @mcollina