Expose current Aedes version, used in aedes-stats

[gnought]

No description provided.

[mcollina]

Can you add it to the prototype as well? aedes-stats should receive an instance of Aedes.

[mcollina]

Also, can you add a unit test?

[gnought]

I think the unit test should be in aedes-stats project.
I will add the code
doPub('version', aedesInstance.constructor.version)
in aedes-stats iterate() function https://github.com/mcollina/aedes-stats/blob/master/stats.js#L52

[mcollina]

This should just check that the version exposed is the same one of the package.json. Il giorno dom 11 ago 2019 alle 10:05 Gnought <[email protected]> ha scritto:

…

I think the unit test should be in aedes-stats project. I will add the code doPub('version', aedesInstance.constructor.version) in aedes-stats iterate() function https://github.com/mcollina/aedes-stats/blob/master/stats.js#L52 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#294>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAMXY7FGLFG5ADW6HF67SDQD7B6DANCNFSM4IK24XLQ> .

[gnought]

Add to prototype could be, but it will require an extra memory for storing version in each instance, and it is not useful for user except aedes-stats.
Version won’t change in each instance, except a user packs two aedes package. In this case he still can get different version using aedes.constructor.version, right?

[gnought]

My idea is also be memory-wise

[mcollina]

The following will not cause any addition memory allocation:

Aedes.prototype.version =  require('./package').version

The reason for that is that it will stick the value on the prototype itself. Instances will look the value there, much like any additional function.

[mcollina]

can you check if the content is the same of package.json?

[mcollina]

LGTM