Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test & added test plan number #290

Merged
merged 8 commits into from
Aug 11, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Aug 10, 2019

For robustness, it is safer to state test plan number.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnought
Copy link
Collaborator Author

gnought commented Aug 10, 2019

@mcollina The upcoming PR mostly are enhancements/optimization, and some minor bug fixes except the attempt of fixing the maximum stack size exceeded.
We could do a release for let our users not to wait too long. :)

@gnought gnought changed the title Added test plan number Enhance test & added test plan number Aug 10, 2019
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM still, good work!

@gnought gnought merged commit e2d64b2 into moscajs:master Aug 11, 2019
@gnought gnought deleted the feature/enhance_tests branch August 11, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants