Downgrade qos to client sub if needed #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Feb 2, 2019
| delete packet.messageId | ||
| t.deepEqual(packet, expected, 'packet must match') | ||
| t.end() | ||
| }) |
There was a problem hiding this comment.
Can you add some checks on the follow up packets to verify that the full QoS flow is respected?
There was a problem hiding this comment.
@mcollina I was just checking. You have helper functions in place to check the QoS flow.
https://github.com/mcollina/aedes/blob/ca42eb0164e08538cabf2ddaa087ef1ff4b9dc8e/test/qos2.js#L11-L46 and https://github.com/mcollina/aedes/blob/ca42eb0164e08538cabf2ddaa087ef1ff4b9dc8e/test/helper.js#L77-L96
|
Yes we do! Can you use them in this test? |
|
@mcollina I've already used the publish and subscribe helper functions in the test 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #208