[Security] Fixed issue #214 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Security fix is only the part where the |
mhverbakel
approved these changes
Aug 28, 2018
mcollina
reviewed
Aug 28, 2018
| @@ -41,7 +42,7 @@ function handleConnect (client, packet, done) { | |||
| } | |||
|
|
|||
| client.id = packet.clientId || uuid.v4() | |||
| client.will = packet.will | |||
| client._will = packet.will | |||
There was a problem hiding this comment.
Can you please restore this?
There was a problem hiding this comment.
Restoring this would mean that the LWT is still sent in case the authentication fails or the client times out before the authentication is resolved
There was a problem hiding this comment.
Can you please add the definition of this property to lib/client.js with a comment explaining it?
| @@ -71,29 +72,28 @@ function authenticate (arg, done) { | |||
| function negate (err, successful) { | |||
| var errCode | |||
| if (!err && successful) { | |||
| client.broker.registerClient(client) | |||
There was a problem hiding this comment.
It is not removed but moved to a separate function which is executed after the will was stored. Check line 21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #214. It turned out that LWT are being stored and sent on authentication failure as well. I fixed that and added 2 test cases - one for keep-alive timeout being triggered during authentication and one for authentication failure.