delivers a will waits for authorization #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mhverbakel
suggested changes
Aug 13, 2018
lib/client.js
Outdated
| that.broker.persistence.delWill({ | ||
| id: that.id, | ||
| brokerId: that.broker.id | ||
| }, nop) | ||
| } | ||
| } | ||
| }) | ||
| that.will = null // this function might be called twice |
There was a problem hiding this comment.
Removing this line here allows the function to be called twice. You should leave this line, and make an in-closure variable for that.will.
mhverbakel
approved these changes
Aug 13, 2018
mcollina
requested changes
Aug 13, 2018
lib/client.js
Outdated
| @@ -258,7 +258,7 @@ Client.prototype.close = function (done) { | |||
| } | |||
| } | |||
| }) | |||
| that.will = null // this function might be called twice | |||
| that._finished = true // this function might be called twice | |||
There was a problem hiding this comment.
a better solution is to extract that.will into a variable, and keep that into the context of the closure.
There was a problem hiding this comment.
@mcollina Thanks you, sir!
test/will.js
Outdated
| let authorized = false | ||
| var opts = {} | ||
| // willConnect populates opts with a will | ||
| var s = willConnect(setup(aedes({ authorizePublish: (_1, _2, callback) => { authorized = true; setTimeout(() => { callback(null) }, 10) } })), opts) |
There was a problem hiding this comment.
Can you shorten up the line and use a setImmediate instead?
There was a problem hiding this comment.
@mcollina Thanks you, sir!
…zePublish and use setImmediate instead of setTimeout in will test
mcollina
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for crash at comment