Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing events according to the docs. #197 #198

Merged
merged 2 commits into from
May 22, 2018
Merged

Added missing events according to the docs. #197 #198

merged 2 commits into from
May 22, 2018

Conversation

bsommardahl
Copy link
Contributor

No description provided.

@mcollina
Copy link
Collaborator

Thanks! Can you add a unit test for this in https://github.com/mcollina/aedes/tree/master/test/typescript?

@bsommardahl
Copy link
Contributor Author

I added some console logs like I found in the file. Is there something in the build pipeline that actually converts those somehow to real unit tests?

@bsommardahl bsommardahl force-pushed the master branch 2 times, most recently from d90472e to 21eb7f2 Compare May 21, 2018 20:28
@mcollina
Copy link
Collaborator

no, we are just validating that typescript can compile this.

mcollina
mcollina approved these changes May 22, 2018
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit de7742f into moscajs:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsommardahl @mcollina