test for #158 #170
Merged
test for #158 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean clients should not have persistent subscription records. #158
|
Subscriptions are cleared on connect https://github.com/cordovapolymer/aedes/blob/5a4210ad477bd2477be2748a19485a4e5f7a173b/lib/handlers/connect.js#L96-L99. You should put some assertions on the persistence itself if you want to check that they should not be stored. |
|
@mcollina |
mcollina
reviewed
Nov 14, 2017
| var subscriber = connect(setup(broker), { clean: true, clientId: 'abcde' }) | ||
|
|
||
| subscribe(t, subscriber, 'hello', 0, function () { | ||
| subscriber.inStream.end() |
There was a problem hiding this comment.
you should check after this, not after reconnection.
There was a problem hiding this comment.
thanks! corrected that, now it fails on a master without a patch from @sundryp
|
Can you remove the yarn-lock file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina
Please see my test for #158
It doesn't fail without the patch from #158 ..
Am I doing it right?