fix(types): update username and password type definition (#806)

moscajs · Jan 13, 2023 · 7c2a2b9 · 7c2a2b9
1 parent 8b14873
commit 7c2a2b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/test/types/aedes.test-d.ts b/test/types/aedes.test-d.ts
@@ -29,7 +29,7 @@ broker = new Aedes({
       callback(new Error('connection error'), false)
     }
   },
-  authenticate: (client: Client, username: Readonly<string>, password: Readonly<Buffer>, callback) => {
+  authenticate: (client: Client, username: Readonly<string | undefined>, password: Readonly<Buffer | undefined>, callback) => {
     if (username === 'test' && password === Buffer.from('test') && client.version === 4) {
       callback(null, true)
     } else {

diff --git a/types/instance.d.ts b/types/instance.d.ts
@@ -29,8 +29,8 @@ declare module 'aedes' {
 
   type AuthenticateHandler = (
     client: Client,
-    username: Readonly<string>,
-    password: Readonly<Buffer>,
+    username: Readonly<string | undefined>,
+    password: Readonly<Buffer | undefined>,
     done: (error: AuthenticateError | null, success: boolean | null) => void
   ) => void