Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added missing instance destroy to fix tests on cached persistences #54

Merged
merged 1 commit into from
Feb 27, 2020
Merged

fix: Added missing instance destroy to fix tests on cached persistences #54

merged 1 commit into from
Feb 27, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando requested a review from gnought February 27, 2020 15:08
mcollina
mcollina approved these changes Feb 27, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit 278e2cb into master Feb 27, 2020
@robertsLando robertsLando deleted the patch-1 branch February 27, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gnought gnought Awaiting requested review from gnought

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @mcollina