Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github checkout actions & drop node 8 #52

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Upgrade github checkout actions & drop node 8 #52

merged 3 commits into from
Feb 25, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 25, 2020

No description provided.

@gnought gnought requested a review from mcollina February 25, 2020 12:46
robertsLando
robertsLando approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando
Copy link
Member

@gnought I think we can drop nodejs 8 like aedes

@gnought
Copy link
Collaborator Author

gnought commented Feb 25, 2020

depends on @mcollina decision

@mcollina
Copy link
Collaborator

let’s do that

@gnought gnought changed the title Upgrade github checkout actions & support node>=8 Upgrade github checkout actions & drop node 8 Feb 25, 2020
robertsLando
robertsLando approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnought gnought merged commit aa6fa7b into moscajs:master Feb 25, 2020
@gnought gnought deleted the feature/update branch February 25, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnought @robertsLando @mcollina