Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use release-it for releases #50

Merged
merged 2 commits into from
Feb 25, 2020
Merged

chore: Use release-it for releases #50

merged 2 commits into from
Feb 25, 2020

Conversation

robertsLando
Copy link
Member

No description provided.

mcollina
mcollina approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought
Copy link
Collaborator

gnought commented Feb 25, 2020

could we add --disable-metrics ?

@gnought
Copy link
Collaborator

gnought commented Feb 25, 2020

IMO, it captures too much metrics.

@robertsLando
Copy link
Member Author

@gnought I have disabled them now

gnought
gnought approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@gnought gnought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando
Copy link
Member Author

If this setup is ok for you we can go on and make this even for others repos

@gnought
Copy link
Collaborator

gnought commented Feb 25, 2020

Could we have a dry run to see how it performs?
I think the only we can’t automate is to define it is major or minor, and beta or alpha, and the otp.

@robertsLando
Copy link
Member Author

@gnought Yes, use --dry-run

@robertsLando
Copy link
Member Author

Can I merge this?

@robertsLando robertsLando merged commit 5998347 into master Feb 25, 2020
@robertsLando robertsLando deleted the release-script branch February 25, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnought gnought gnought approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertsLando @gnought @mcollina