Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for concurrent subscriptions & update qlobber #26

Merged
merged 3 commits into from
Nov 20, 2018
Merged

add test for concurrent subscriptions & update qlobber #26

merged 3 commits into from
Nov 20, 2018

Conversation

behrad
Copy link
Collaborator

@behrad behrad commented Nov 20, 2018

@mcollina
Copy link
Collaborator

would you also attempt a fix?

@behrad
Copy link
Collaborator Author

behrad commented Nov 20, 2018

fix will be inside https://github.com/mcollina/aedes-cached-persistence

@behrad
Copy link
Collaborator Author

behrad commented Nov 20, 2018

I should depend on this when merged to test

@behrad
Copy link
Collaborator Author

behrad commented Nov 20, 2018

This should now pass @mcollina
I will provide another PR in a few minutes to fix moscajs/aedes-cached-persistence#12

@behrad behrad requested a review from mcollina November 20, 2018 10:15
mcollina
mcollina approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 93d7927 into moscajs:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behrad @mcollina