Publish client sub #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2017
mcollina
reviewed
Jul 14, 2017
There was a problem hiding this comment.
Are you think in other breaking changes to aedes-persistence?
Would you minding firing a PR for https://github.com/mcollina/aedes-persistence-mongodb as well?
index.js
Outdated
| topic: newSubTopic, | ||
| brokerPublish: brokerPublish | ||
| } | ||
| ctx.brokerPublish(subs, addedSubDone.bind(ctx)) |
There was a problem hiding this comment.
bind is slow in Node 4 and 6, would you mind using an arrow function or a closure?
|
I don't think anything related to aedes-persistence interface is touched. |
|
@mcollina |
|
Can you check this now alongside moscajs/aedes-persistence-redis#34 & moscajs/aedes-persistence-mongodb#9 @mcollina ? |
|
Any updates on this? |
|
👍 great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachedPersistence#_waitForinterface is changed!I couldn't keep it unchanged, since all children should now call _waitFor only once!