Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: transaction split endpoints integration tests #27

Closed
wants to merge 6 commits into from
Closed

tests: transaction split endpoints integration tests #27

wants to merge 6 commits into from

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Oct 13, 2023

No description provided.

@Lilit0x Lilit0x marked this pull request as draft October 13, 2023 10:57
@Lilit0x Lilit0x changed the title Draft: tests: transaction split endpoints integration tests tests: transaction split endpoints integration tests Oct 13, 2023
@morukele
Copy link
Owner

Hi @Lilit0x I see that this is a draft, keep up the good work.

@morukele
Copy link
Owner

@Lilit0x I wanted to inform you that I have made some changes to the SubaccountBodyBuilder, there was a problem with a field in this struct which gives an error when calling the API.

If you pull the latest version of the code, you will see the update.

@morukele morukele marked this pull request as ready for review October 29, 2023 18:19
@morukele
Copy link
Owner

@Lilit0x Tests are failing, get the latest version of the code to work with.

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Oct 29, 2023

@Lilit0x Tests are failing, get the latest version of the code to work with.

Hi there.
Thanks, I will pull the code and fix the issues.

@morukele
Copy link
Owner

@Lilit0x still getting failed tests.

Did you use a valid paystack API key?

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Oct 29, 2023

@Lilit0x still getting failed tests.

Did you use a valid paystack API key?

Hi there, yes, I did.

Screenshot (272)

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Oct 29, 2023

Or do I have to add the key to my own actions on GitHub?

@morukele
Copy link
Owner

Or do I have to add the key to my own actions on GitHub?

I think you may have to. I have my own keys on GitHub actions, try adding to your actions, then let me know so I can run the tests to check.

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Oct 29, 2023

Or do I have to add the key to my own actions on GitHub?

I think you may have to. I have my own keys on GitHub actions, try adding to your actions, then let me know so I can run the tests to check.

I have added it and the remaining env variables too

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Oct 29, 2023

I ran the tests on my own fork, and they failed too. I'll try to figure out the issue and get back to you tomorrow.
If I am not able to fix it by then, I don't know if you'll be willing to get on a 15 to 30 minutes call to sort it out.

@morukele
Copy link
Owner

It is strange that all tests pass on your local machine but not on GitHub.

No problem at all, let me know tomorrow evening and we can get on a google-meet if necessary.

@Lilit0x Lilit0x closed this by deleting the head repository Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants