Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo support #37

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Conversation

clmoreno
Copy link
Contributor

@clmoreno clmoreno commented Mar 8, 2024

Example upgrade and monorepo support

Example project

  • It was upgraded to expo 50

Plugin

  • Added support for monorepos
    As Expo documentation describes, to be able to support monorepos there must be changed the way file paths and packages are obteined ( source )
  • Removed unused code.
    cocoaPods function was not used so it was removed.
  • ios pods
    • WatermelonDB and React-jsi are autolinked automatically

@clmoreno clmoreno changed the title Task/upgrade example Monorepo support Mar 8, 2024
@killerchip
Copy link
Contributor

Thanks @clmoreno.
Testing it!

@killerchip killerchip changed the base branch from main to beta March 20, 2024 15:17
Copy link
Contributor

@killerchip killerchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on line 402
currentConfig = setWmelonBridgingHeader(currentConfig);
is not a duplicate call.

@killerchip killerchip self-requested a review March 20, 2024 15:26
Copy link
Contributor

@killerchip killerchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove approval atm

@clmoreno
Copy link
Contributor Author

The change on line 402 currentConfig = setWmelonBridgingHeader(currentConfig); is not a duplicate call.

I think that on expo 50 it is not necessary, on expo 50, expo already includes a .swift file for that purpose.

@killerchip killerchip merged commit 21a0ce3 into morrowdigital:beta Mar 21, 2024
killerchip added a commit that referenced this pull request Apr 27, 2024
* Monorepo support (#37)

* Upgrade to expo 50 sdk

* Upgrade morrowdigital/watermelondb-expo-plugin

* Add Android monorepo support

* Add ios monorepo support

- Adds monorepo support to ios
- Removes unnecessary pods as they are already auto-linked

* Remove unused code

* Remove duplicated bridgingHeader

Expo 50 there is already an empty .swift file for this

* Add monorepo support

* apply changes to build

* bump version 2.3.2-beta.0

* Chore/docs update (#38)

* add changelog and contributions

* maintainer's guide

* Chore/GitHub actions (#39)

* 2.3.2-beta.1

* add pushing back to repo

* remove dry-run

* github actions / add beta action

* chore/fix git push

* remove version bump

* add Environment again

* add version bumping

* removed version upgrade

* added npm token placeholder

* different npm token in previous step

* add yarn gha

* more places for NPM_TOKEN

* Chore/update docs on gha (#40)

* update docs and npmrc

* update releaes gha

* bugfix/revert test code

* 2.3.2

* update CHANGELOG.md

---------

Co-authored-by: Carlos Moreno <[email protected]>
killerchip added a commit that referenced this pull request May 26, 2024
* Monorepo support (#37)

* Upgrade to expo 50 sdk

* Upgrade morrowdigital/watermelondb-expo-plugin

* Add Android monorepo support

* Add ios monorepo support

- Adds monorepo support to ios
- Removes unnecessary pods as they are already auto-linked

* Remove unused code

* Remove duplicated bridgingHeader

Expo 50 there is already an empty .swift file for this

* Add monorepo support

* apply changes to build

* bump version 2.3.2-beta.0

* Chore/docs update (#38)

* add changelog and contributions

* maintainer's guide

* Chore/GitHub actions (#39)

* 2.3.2-beta.1

* add pushing back to repo

* remove dry-run

* github actions / add beta action

* chore/fix git push

* remove version bump

* add Environment again

* add version bumping

* removed version upgrade

* added npm token placeholder

* different npm token in previous step

* add yarn gha

* more places for NPM_TOKEN

* Chore/update docs on gha (#40)

* update docs and npmrc

* update releaes gha

* bugfix/revert test code

* 2.3.2

* update CHANGELOG.md

* Fix re runs (#43)

* fix prebuild duplicating content

* re-build

* fix duplication on podfile

---------

Co-authored-by: Harrison Mendonça <[email protected]>

* 2.3.3-beta.0

* bump version

* 2.3.3-beta.1

* update changelog

* fix documentation on disableJSI option

* 2.3.3

* update readme

---------

Co-authored-by: Carlos Moreno <[email protected]>
Co-authored-by: Harrison Mendonça <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants