-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo support #37
Monorepo support #37
Conversation
- Adds monorepo support to ios - Removes unnecessary pods as they are already auto-linked
Expo 50 there is already an empty .swift file for this
Thanks @clmoreno. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change on line 402
currentConfig = setWmelonBridgingHeader(currentConfig);
is not a duplicate call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove approval atm
I think that on expo 50 it is not necessary, on expo 50, expo already includes a .swift file for that purpose. |
* Monorepo support (#37) * Upgrade to expo 50 sdk * Upgrade morrowdigital/watermelondb-expo-plugin * Add Android monorepo support * Add ios monorepo support - Adds monorepo support to ios - Removes unnecessary pods as they are already auto-linked * Remove unused code * Remove duplicated bridgingHeader Expo 50 there is already an empty .swift file for this * Add monorepo support * apply changes to build * bump version 2.3.2-beta.0 * Chore/docs update (#38) * add changelog and contributions * maintainer's guide * Chore/GitHub actions (#39) * 2.3.2-beta.1 * add pushing back to repo * remove dry-run * github actions / add beta action * chore/fix git push * remove version bump * add Environment again * add version bumping * removed version upgrade * added npm token placeholder * different npm token in previous step * add yarn gha * more places for NPM_TOKEN * Chore/update docs on gha (#40) * update docs and npmrc * update releaes gha * bugfix/revert test code * 2.3.2 * update CHANGELOG.md --------- Co-authored-by: Carlos Moreno <[email protected]>
* Monorepo support (#37) * Upgrade to expo 50 sdk * Upgrade morrowdigital/watermelondb-expo-plugin * Add Android monorepo support * Add ios monorepo support - Adds monorepo support to ios - Removes unnecessary pods as they are already auto-linked * Remove unused code * Remove duplicated bridgingHeader Expo 50 there is already an empty .swift file for this * Add monorepo support * apply changes to build * bump version 2.3.2-beta.0 * Chore/docs update (#38) * add changelog and contributions * maintainer's guide * Chore/GitHub actions (#39) * 2.3.2-beta.1 * add pushing back to repo * remove dry-run * github actions / add beta action * chore/fix git push * remove version bump * add Environment again * add version bumping * removed version upgrade * added npm token placeholder * different npm token in previous step * add yarn gha * more places for NPM_TOKEN * Chore/update docs on gha (#40) * update docs and npmrc * update releaes gha * bugfix/revert test code * 2.3.2 * update CHANGELOG.md * Fix re runs (#43) * fix prebuild duplicating content * re-build * fix duplication on podfile --------- Co-authored-by: Harrison Mendonça <[email protected]> * 2.3.3-beta.0 * bump version * 2.3.3-beta.1 * update changelog * fix documentation on disableJSI option * 2.3.3 * update readme --------- Co-authored-by: Carlos Moreno <[email protected]> Co-authored-by: Harrison Mendonça <[email protected]>
Example upgrade and monorepo support
Example project
Plugin
As Expo documentation describes, to be able to support monorepos there must be changed the way file paths and packages are obteined ( source )
cocoaPods function was not used so it was removed.