Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 48 'Modular Headers' Fix #16

Merged
merged 9 commits into from
May 12, 2023

Conversation

TheLonelyAstronaut
Copy link
Contributor

@TheLonelyAstronaut TheLonelyAstronaut commented May 9, 2023

This small PR fixes #15 - EAS build for SDK48 and WatermelonDB v0.26.0

@TheLonelyAstronaut TheLonelyAstronaut marked this pull request as draft May 9, 2023 21:33
@TheLonelyAstronaut TheLonelyAstronaut marked this pull request as ready for review May 10, 2023 04:12
@brunokiafuka
Copy link
Collaborator

Hi @TheLonelyAstronaut thanks for making this fix, will you be able to rebase your branch so we can safely merge.

@brunokiafuka
Copy link
Collaborator

One last request please test it under example/* by upgrading the watermelon version on example app.

@brunokiafuka brunokiafuka merged commit c46c975 into morrowdigital:main May 12, 2023
@TheLonelyAstronaut
Copy link
Contributor Author

@brunokiafuka are you able to test a plugin by building expo dev client? Looks like it's compiles fine, but when you try to use complex models (with lazy decorators, actions and so on) it just crashes with "undefined is not an object"

@brunokiafuka
Copy link
Collaborator

@brunokiafuka are you able to test a plugin by building expo dev client? Looks like it's compiles fine, but when you try to use complex models (with lazy decorators, actions and so on) it just crashes with "undefined is not an object"

I've made a few tweaks but all runs fine, just testing with watermelon v0.26.0

@TheLonelyAstronaut
Copy link
Contributor Author

@brunokiafuka tested with lazy, its fine. But adding @actions brakes all, could you share example?

@brunokiafuka
Copy link
Collaborator

you can branch out the basic starter example on the project here

@TheLonelyAstronaut
Copy link
Contributor Author

@brunokiafuka huh, sorry, i picked an example from Watermelon repo, it has old library version with deprecated @action hook, all is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo Dev Client Build Crashes: use_modular_headers!
2 participants