Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prebuild error fix for app name with spaces #11

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

billjohnston
Copy link
Contributor

Fix for this error I was getting during prebuild:

- Config syncing
✖ Config sync failed
[stderr] [12:32:43] [ios.dangerous]: withIosDangerousBaseMod: ENOENT: no such file or directory, open '/Users/expo/workingdir/build/ios/My App Name/wmelon.swift'
[stderr] [12:32:43] Error: [ios.dangerous]: withIosDangerousBaseMod: ENOENT: no such file or directory, open '/Users/expo/workingdir/build/ios/My App Name/wmelon.swift'
[stderr] error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn exited with non-zero code: 1

Think it was associated to my app name having spaces and this code:

config.modRequest.projectRoot + "/ios", config.name.replace("-", "")

Was returning an incorrect projectName

Kinda new to RN and am happy to make edits to this if anyone has more context

@brunokiafuka brunokiafuka self-requested a review February 14, 2023 07:59
Copy link
Collaborator

@brunokiafuka brunokiafuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billjohnston thanks for this.

We didn't account for apps where display names include spaces. ie.: Nike Run Club. I've reproduced the issue and tested changes and they fix the issue.

@brunokiafuka brunokiafuka merged commit 1060459 into morrowdigital:main Feb 14, 2023
@brunokiafuka brunokiafuka changed the title Prebuild error fix for app name with spaces [fix] prebuild error fix for app name with spaces Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants