Add include/exclude regex pattern to filter search result #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can simply do "pip install -r requirements.txt"
Allow to filter search result by title
|
looking for testers |
|
You can trash my PR, it will not be a problem for me... But I'm curious about the JSON structure. Why have you nested the minPrice and maxPrice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include/exclude filter are applied on item title, and saved in the json.
I'm not very happy of my solution. I'm spoking about
print_sitrep()andprint_queries()nested loop.Honestly, I'm lost inside the multiple loops
for, and I don't well figure out the logic behind the json structure, expecially the position of minPrice and maxPrice.{minPrice: {maxPrice: {...For sure I have missed something in the program logic and structure...but my PR seems works.
About the minPrice and maxPrice, I see that subito.it have GET params (ps=30&pe=100), but can be used only inside a category, I guess.
I have also added a simple
requirements.txt.Thanks for your time and project!
note: you can do what ever you want with this PR...I have try to leave as much possible unchanged your code, but IMHO a different JSON structure and/or removing the
[min,max]Pricecould be a way.