Enable lLTV #73
Merged
Enable lLTV #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
Rubilmax,
QGarchery,
pakim249CAL and
MathisGD
MathisGD
reviewed
Jul 6, 2023
MathisGD
requested changes
Jul 6, 2023
MerlinEgalite
force-pushed
the
feat/irm-whitelist
branch
from
1f703a6
to
fe71f20
Compare
|
weird seems that there's an issue with the naming while in local it's passing... Actually the naming of interfaces is different from what I have in local. EDIT: solve following this tuto: https://code-garage.fr/blog/resoudre-les-problemes-de-casse-avec-les-noms-de-fichiers-sous-git/ |
makcandrov
previously approved these changes
Jul 6, 2023
Rubilmax
previously approved these changes
Jul 7, 2023
MathisGD
previously approved these changes
Jul 7, 2023
pakim249CAL
previously approved these changes
Jul 7, 2023
QGarchery
previously approved these changes
Jul 8, 2023
MerlinEgalite
dismissed stale reviews from QGarchery, pakim249CAL, MathisGD, Rubilmax, and makcandrov
The base branch was changed.
pakim249CAL
reviewed
Jul 8, 2023
pakim249CAL
approved these changes
Jul 9, 2023
MathisGD
approved these changes
Jul 10, 2023
Rubilmax
approved these changes
Jul 10, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42
Question: should we rename
lLTVtoliquidationLtv? Else we should usefunctionLLTVnaming to follow camelCase pattern