-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IRM call skip #574
Remove IRM call skip #574
Conversation
I restarted the CI but it seems very very slow, I'm not sure why |
I think we should link this PR to https://github.com/cantinasec/review-morpho-blue-1/issues/42 btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check should be removed from libraries too
Talking with @Rubilmax and @MerlinEgalite we found out that removing this check also makes it more complex to enable markets with no borrow, such as the idle market that we consider using in metamorpho. It could still be done by enabling a dummy IRM that does nothing (so it never reverts and doesn't cost much gas to call), but it becomes awkward to do |
note that it's not mandatory as it would give the same result (as we use borrowRateView here, we don't care about calling it or not) |
That seems correct! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be linked to the relevant cantina issue
done |
33924f9
2dcc01b
I think that we should remove the IRM call skip bacause (#460):