Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IRM call skip #574

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD commented Nov 4, 2023

I think that we should remove the IRM call skip bacause (#460):

@MerlinEgalite
Copy link
Contributor

I restarted the CI but it seems very very slow, I'm not sure why

@MerlinEgalite
Copy link
Contributor

I think we should link this PR to https://github.com/cantinasec/review-morpho-blue-1/issues/42 btw

src/mocks/IrmMock.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Nov 6, 2023
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check should be removed from libraries too

@QGarchery
Copy link
Contributor

Talking with @Rubilmax and @MerlinEgalite we found out that removing this check also makes it more complex to enable markets with no borrow, such as the idle market that we consider using in metamorpho. It could still be done by enabling a dummy IRM that does nothing (so it never reverts and doesn't cost much gas to call), but it becomes awkward to do

@MathisGD
Copy link
Contributor Author

MathisGD commented Nov 8, 2023

The check should be removed from libraries too

note that it's not mandatory as it would give the same result (as we use borrowRateView here, we don't care about calling it or not)

@Rubilmax
Copy link
Contributor

Rubilmax commented Nov 8, 2023

note that it's not mandatory as it would give the same result (as we use borrowRateView here, we don't care about calling it or not)

That seems correct!

@MathisGD MathisGD self-assigned this Nov 8, 2023
@MathisGD MathisGD linked an issue Nov 8, 2023 that may be closed by this pull request
Jean-Grimal
Jean-Grimal previously approved these changes Nov 9, 2023
MerlinEgalite
MerlinEgalite previously approved these changes Nov 9, 2023
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be linked to the relevant cantina issue

@MathisGD
Copy link
Contributor Author

MathisGD commented Nov 9, 2023

It must be linked to the relevant cantina issue

done

Rubilmax
Rubilmax previously approved these changes Nov 9, 2023
Jean-Grimal
Jean-Grimal previously approved these changes Nov 9, 2023
QGarchery
QGarchery previously approved these changes Nov 10, 2023
@MerlinEgalite MerlinEgalite merged commit 26e4627 into cantina-review Nov 12, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/remove-skip-irm-call branch November 12, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never skip interest accrual ?
5 participants